Skip to content
This repository has been archived by the owner on Nov 7, 2019. It is now read-only.

Build Statically Linked Binary #201

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Build Statically Linked Binary #201

wants to merge 1 commit into from

Conversation

computeracer
Copy link

@computeracer computeracer commented Jul 11, 2019

Issue #202

Description of changes:

  • We found when building the binary it would not run in the
    container.
  • Adding these variables and flags build a portable self contained
    linux binary.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mhausenblas
Copy link
Contributor

@christopherhein any opinion on this?

@christopherhein
Copy link
Contributor

@computeracer thanks for this PR. Are you trying to use goreleaser to build the images? The Makefile purpose for my use cases was local dev so I could test against a remote cluster then would build my images using goreleaser?

@computeracer
Copy link
Author

computeracer commented Jul 15, 2019 via email

@christopherhein
Copy link
Contributor

@computeracer no but PR's welcome. :) If you check out the Makefile you'll see the make release target, for your own env, you'll need to modify the .goreleaser.yml file in the root and change the dockers[].image param https://github.com/awslabs/aws-service-operator/blob/master/.goreleaser.yml#L45

- We found when building the binary it would not run in the
  container.
- Adding these variables and flags build a portable self contained
  linux binary.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants