This repository has been archived by the owner on Nov 7, 2019. It is now read-only.
WIP: S3 deletion policy #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`make codegen` now builds a new version of the codegen tool before trying to run it. The command also now looks to a binary in the code-generation directory instead of requiring installation. This also adds a `go fmt` command to the code generation to remove formatting diffs from the bindata generation stage.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #126
Description of changes: Adds a string parameter for the BucketDeletionPolicy
Builds on #133 and includes new code from
dep ensureandmake rebuildBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.