Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support charset detector for web #6

Merged
merged 16 commits into from
Mar 4, 2024

Conversation

dab246
Copy link
Contributor

@dab246 dab246 commented Feb 26, 2024

Issue

Desccriptions

  • Use https://www.npmjs.com/package/jschardet to detect charset on web

@dab246
Copy link
Contributor Author

dab246 commented Feb 26, 2024

@amake Please review help me. Thanks

@amake
Copy link
Owner

amake commented Feb 26, 2024

Wow, thanks! This is much appreciated. Please give me a bit of time to take a proper look.

@amake
Copy link
Owner

amake commented Mar 2, 2024

Thank you for your contribution.

I pushed a bunch of fixes for things. I am almost ready to merge, but there are some outstanding issues:

  • It seems that you (or someone) have already claimed the package flutter_charset_detector_web. Are you willing to give this to me? If so, I think I will have to do:
    1. Add you as a member of my publisher
    2. Have you transfer ownership of the package to my publisher
    3. Probably remove you from the publisher
  • The current implementation uses js 0.6.7, which is one major version (equivalent) out of date.
    • Can I update it?
    • Apparently js is deprecated in favor of dart:js_interop; would it be a problem for me to switch to this at some time?

@dab246
Copy link
Contributor Author

dab246 commented Mar 4, 2024

Thank you for your contribution.

I pushed a bunch of fixes for things. I am almost ready to merge, but there are some outstanding issues:

  • It seems that you (or someone) have already claimed the package flutter_charset_detector_web. Are you willing to give this to me? If so, I think I will have to do:

    1. Add you as a member of my publisher
    2. Have you transfer ownership of the package to my publisher
    3. Probably remove you from the publisher
  • The current implementation uses js 0.6.7, which is one major version (equivalent) out of date.

    • Can I update it?
    • Apparently js is deprecated in favor of dart:js_interop; would it be a problem for me to switch to this at some time?

That's great, thank you.

  • Yes, I myself published the package flutter_charset_detector_web. I am willing to transfer ownership of that package to your publisher, so please add me as a member of my publisher
  • IMO, at this point we can still use it.

@amake
Copy link
Owner

amake commented Mar 4, 2024

Thanks! I've invited you to the publisher via the email address on your GitHub profile.

@dab246
Copy link
Contributor Author

dab246 commented Mar 4, 2024

Thanks! I've invited you to the publisher via the email address on your GitHub profile.

@amake Sorry I use this email [email protected] for my pub.dev. Please invite me back via this email. Sorry for the inconvenience. Thanks.

@amake
Copy link
Owner

amake commented Mar 4, 2024

OK I've invited you.

@dab246
Copy link
Contributor Author

dab246 commented Mar 4, 2024

OK I've invited you.

II have successfully transferred flutter_charset_detector_web to your publisher. Please do further work to merge this PR soon. Thanks a lot.

@amake
Copy link
Owner

amake commented Mar 4, 2024

OK thanks, I'll take it from here.

@amake amake merged commit 4b66ee0 into amake:master Mar 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants