task 3#30
Open
ILBAYIL wants to merge 8 commits into
Open
Conversation
Owner
|
По ЛР3
|
alvls
reviewed
May 23, 2024
Comment on lines
+9
to
+14
| std::string titles[MAX_SONGS]; | ||
| std::string artists[MAX_SONGS]; | ||
| std::string albums[MAX_SONGS]; | ||
| int releaseDays[MAX_SONGS]; | ||
| int releaseMonths[MAX_SONGS]; | ||
| int releaseYears[MAX_SONGS]; |
Owner
There was a problem hiding this comment.
Было бы правильнее создать класс Песня, в который поместить ее параметры. А в Песенник включить массив песен.
alvls
reviewed
May 23, 2024
| numSongs++; | ||
| } | ||
| else { | ||
| std::cout << "�������� ����������" << std::endl; |
Owner
There was a problem hiding this comment.
Здесь и в других методах в случае ошибок правильнее бросить исключение. Выводить на консоль - плохое решение.
alvls
reviewed
May 23, 2024
Comment on lines
+53
to
+54
| std::cout << "����� �������:" << std::endl; | ||
| std::cout << titles[i] << " ������������ " << artists[i] << std::endl; |
Owner
There was a problem hiding this comment.
В результате поиска нужно вернуть найденную песню, а не вывести ее на консоль.
Owner
|
По ЛР4
Будете пытаться исправить? |
Owner
|
По ЛР5
|
Owner
|
По ЛР6 В целом годится, кроме жуткого мерцания экрана.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Мне говорили, что нельзя, чтобы класс разговаривал с пользователем, но я тогда не понимаю в чем смысл такого класса и как с ним взаимодействовать в таком случае. Поэтому надеюсь так подойдет