Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a process bug when running show commands on Windows #330

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

damienstanton
Copy link

With the released version, all gitu commands for showing, editing etc. using the EDITOR env var and others will fail because we try to launch the subprocess command directly.

On Windows, this doesn't work; Commands need to be prepended with cmd /C to be executed in sub-shells.

@damienstanton
Copy link
Author

Note that there are some tests that this currently breaks, so I'll fix these before calling it ready to merge.

Copy link

codecov bot commented Mar 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.73%. Comparing base (c772624) to head (ead232d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
+ Coverage   87.71%   87.73%   +0.01%     
==========================================
  Files          63       63              
  Lines        5627     5636       +9     
==========================================
+ Hits         4936     4945       +9     
  Misses        691      691              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant