Skip to content

net: eth: altera: fix phy-handle not find issue #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: socfpga-6.12.11-lts
Choose a base branch
from

Conversation

MarileneGarcia
Copy link
Contributor

@MarileneGarcia MarileneGarcia commented Jun 29, 2025

Description:
The function phylink_of_phy_connect() returns 0 in case of success.
So, if the phy-handle attribute was found, it will return 0, but phydev will still contain the value NULL, and it will enter the condition if(!phydev) and return an error even in the successful case.

Impact Analysis:

What is the scope of the change and the purpose of the change?
It will return the same value as phylink_of_phy_connect() in case of success, the value 0. So, there is no need to check the condition if(!phydev).

The function phylink_of_phy_connect() returns 0 in case of success.
So, if the phy-handle attribute was found, it will return 0, but
phydev will still contain the value NULL, and it will enter the
condition if(!phydev) and return an error even in the successful case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant