refactor: 사용자 자신의 스케줄 조회 API 스펙 변경 #60
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juny0955
approved these changes
Jan 12, 2026
ysw789
requested changes
Jan 12, 2026
Contributor
ysw789
left a comment
ysw789
left a comment
There was a problem hiding this comment.
논의했던 대로 스펙 수정 바랍니다
- 인자 없이 요청 시 해당 주의 스케줄 전체 반환
- 년/월/일 포함 시 해당 날짜의 스케줄 반환
- 년/월 포함 시 해당 월의 스케줄 반환
...a/com/dreamteam/alter/adapter/inbound/general/schedule/dto/MyScheduleMonthlyResponseDto.java
Outdated
Show resolved
Hide resolved
ysw789
requested changes
Jan 14, 2026
| @Service("getMySchedule") | ||
| @Transactional(readOnly = true) | ||
| @RequiredArgsConstructor | ||
| public class GetMySchedule implements GetMyScheduleInquiryUseCase { |
Contributor
There was a problem hiding this comment.
인터페이스 이름이랑 구현체 이름이랑 맞춰주세요
복잡한 네이밍보단 기존 네이밍 유지하는 게 적절해보입니다 GetMyScheduleUseCase GetMySchedule
|
|
||
| List<WorkspaceShift> shifts; | ||
|
|
||
| if (request.getYear() != null && request.getMonth() != null && request.getDay() != null) { |
Contributor
There was a problem hiding this comment.
null check는 org.apache.commons.lang3.ObjectUtils 의 isEmpty(), isNotEmpty() 활용해주세요 (34, 42, 49행 전부 포함)
다른 UseCase들 구현 참조
| @AllArgsConstructor(access = AccessLevel.PRIVATE) | ||
| @Builder(access = AccessLevel.PRIVATE) | ||
| @Schema(description = "스케줄 조회 통합 응답") | ||
| public class MyScheduleInquiryResponseDto { |
Contributor
There was a problem hiding this comment.
응답 DTO 클래스 이름도 단순화 해도 괜찮을 것 같네요
GetMyScheduleResponseDto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 문서
작업문서링크