added exception sink facet to codemirror

altair-graphql · Dec 2, 2023 · ae9c0cb · ae9c0cb
1 parent 9bfc270
commit ae9c0cb
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/packages/altair-api/package.json b/packages/altair-api/package.json
@@ -78,7 +78,7 @@
     "prebuild": "rimraf dist",
     "start": "nest start",
     "start:debug": "nest start --debug --watch",
-    "start:dev": "nest start --watch",
+    "start:dev": "rm dist && nest start --watch",
     "start:prod": "node dist/main",
     "migrate:e2e": "dotenv -e .env.e2e -- prisma migrate deploy --schema ../altair-db/prisma/schema.prisma",
     "test": "jest",

diff --git a/packages/altair-app/src/app/modules/altair/components/codemirror/codemirror.component.ts b/packages/altair-app/src/app/modules/altair/components/codemirror/codemirror.component.ts
@@ -47,6 +47,7 @@ import {
 } from '@codemirror/language';
 
 import { tags as t } from '@lezer/highlight';
+import { InternalEditorError } from '../../utils/errors';
 
 @Component({
   selector: 'app-codemirror',
@@ -177,6 +178,9 @@ export class CodemirrorComponent
         this.zone.run(() => this.focusChanged(vu.view.hasFocus));
       }
     });
+    const exceptionSink = EditorView.exceptionSink.of((exception) => {
+      throw new InternalEditorError(exception);
+    });
     const baseTheme = EditorView.theme({
       '&.cm-editor': {
         cursor: 'text',
@@ -398,6 +402,7 @@ export class CodemirrorComponent
 
     return [
       updateListener,
+      exceptionSink,
       Prec.highest(extraExtensions),
       !this.bare ? [...baseExtensions] : [],
 

diff --git a/packages/altair-app/src/app/modules/altair/utils/errors.ts b/packages/altair-app/src/app/modules/altair/utils/errors.ts
@@ -9,3 +9,16 @@ export const catchUselessObservableError = catchError((err) => {
   debug.error(err);
   return EMPTY;
 });
+
+class BaseError extends Error {
+  constructor(message: string, options?: { cause: unknown }) {
+    super(message, options);
+    this.name = this.constructor.name;
+  }
+}
+
+export class InternalEditorError extends BaseError {
+  constructor(cause: unknown) {
+    super('Internal editor error occurred', { cause });
+  }
+}