Merge pull request #600 from alsuren/dependabot/cargo/uuid-1.15.1 #1644
qwandorAnnotations
8 warnings
|
accessing first element with `nodes.get(0)`:
applehat/src/ui.rs#L76
warning: accessing first element with `nodes.get(0)`
--> applehat/src/ui.rs:76:52
|
76 | if let Some((device_id, node_id, _)) = nodes.get(0) {
| ^^^^^^^^^^^^ help: try: `nodes.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `#[warn(clippy::get_first)]` on by default
|
|
direct implementation of `ToString`:
homie-controller/src/values.rs#L297
warning: direct implementation of `ToString`
--> homie-controller/src/values.rs:297:1
|
297 | / impl ToString for EnumValue {
298 | | fn to_string(&self) -> String {
299 | | self.0.to_string()
300 | | }
301 | | }
| |_^
|
= help: prefer implementing `Display` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
= note: `#[warn(clippy::to_string_trait_impl)]` on by default
|
|
operator precedence can trip the unwary:
btsensor/src/bthome/v2.rs#L306
warning: operator precedence can trip the unwary
--> btsensor/src/bthome/v2.rs:306:13
|
306 | Ok((u32::from(a) | u32::from(b) << 8 | u32::from(c) << 16, 3))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `u32::from(a) | (u32::from(b) << 8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
btsensor/src/bthome/v2.rs#L306
warning: operator precedence can trip the unwary
--> btsensor/src/bthome/v2.rs:306:13
|
306 | Ok((u32::from(a) | u32::from(b) << 8 | u32::from(c) << 16, 3))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `u32::from(a) | u32::from(b) << 8 | (u32::from(c) << 16)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
btsensor/src/bthome/v1.rs#L200
warning: operator precedence can trip the unwary
--> btsensor/src/bthome/v1.rs:200:17
|
200 | bytes[0] as i32 | (bytes[1] as i32) << 8 | (bytes[2] as i32) << 16,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `bytes[0] as i32 | ((bytes[1] as i32) << 8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
btsensor/src/bthome/v1.rs#L200
warning: operator precedence can trip the unwary
--> btsensor/src/bthome/v1.rs:200:17
|
200 | bytes[0] as i32 | (bytes[1] as i32) << 8 | (bytes[2] as i32) << 16,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `bytes[0] as i32 | (bytes[1] as i32) << 8 | ((bytes[2] as i32) << 16)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
btsensor/src/bthome/v1.rs#L190
warning: operator precedence can trip the unwary
--> btsensor/src/bthome/v1.rs:190:17
|
190 | bytes[0] as u32 | (bytes[1] as u32) << 8 | (bytes[2] as u32) << 16,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `bytes[0] as u32 | ((bytes[1] as u32) << 8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
btsensor/src/bthome/v1.rs#L190
warning: operator precedence can trip the unwary
--> btsensor/src/bthome/v1.rs:190:17
|
190 | bytes[0] as u32 | (bytes[1] as u32) << 8 | (bytes[2] as u32) << 16,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `bytes[0] as u32 | (bytes[1] as u32) << 8 | ((bytes[2] as u32) << 16)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
= note: `#[warn(clippy::precedence)]` on by default
|