Skip to content

Fix Promise implementation #21

Description

@alshdavid

Currently Promise is instantiated by calling into JavaScript and manually calling globalThis.Promise (as JavaScript).

https://github.com/alshdavid/ion/blob/main/crates/ion/src/values/js_promise.rs#L60

This is insecure and v8 provides APIs to do this. Replace the implementation with the native V8 Promise constructor

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions