Skip to content

fix(devtools): QA feedbacks on the realistic UI preview - #1063

Open
harijoe wants to merge 11 commits into
v2from
julien/sky-557-qa-feedbacks-on-realistic-ui-preview
Open

fix(devtools): QA feedbacks on the realistic UI preview#1063
harijoe wants to merge 11 commits into
v2from
julien/sky-557-qa-feedbacks-on-realistic-ui-preview

Conversation

@harijoe

@harijoe harijoe commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Fixes the QA findings on the DevTools realistic conversation preview (session notes, SKY-557).
  • A modal requested via useRequestModal can now be closed; before, nothing could dismiss it on either client.
  • Leaving fullscreen keeps the widget in view instead of jumping to the top of the thread.
  • Preview skeletons no longer pulse, so the mock conversation stops looking like it is loading.
  • Adds host chrome QA asked for: logos in the switch button, the composer in fullscreen, Claude's scroll-to-bottom arrow.
  • vite.config.ts files use import.meta.dirname, dropping the config-loader warning new projects printed.

Architecture Notes

  • Modal lifecycle sits with the host — the openai mock clears openai.view, so isOpen flips from the store, not from the component.

Alternatives Considered

  • Expose close from useRequestModal — would let the view dismiss its own modal. No real host needs it: ChatGPT owns the chrome, and on an MCP Apps host window.openai is undefined so core's polyfill already closes itself. That would have added permanent v2 public API to paper over a DevTools-only gap.
  • Show the resolved Skybridge version in the DevTools header — was built, then reverted. QA's "stuck at v1.0.0" is the CLI banner, which already reads the installed package correctly; the repo pins 1.0.0 and injects the real version at publish time, so in-repo runs always print it. Nothing to fix, and the header was the wrong home for it.

@greptile-apps

greptile-apps Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR incorporates QA feedback for the realistic DevTools conversation preview.

  • Replaces __dirname with import.meta.dirname in Vite configurations and migration guidance.
  • Stops preview skeletons from pulsing and restores bottom positioning after fullscreen.
  • Adds host-driven modal rendering, Escape handling, close controls, and view-state synchronization.
  • Reverts the attempted Skybridge package-version header after its initial implementation.

Confidence Score: 5/5

The PR appears safe to merge because no blocking failure remains.

No blocking failure remains.

Reviews (2): Last reviewed commit: "revert(devtools): drop the skybridge ver..." | Re-trigger Greptile

@harijoe
harijoe force-pushed the julien/sky-557-qa-feedbacks-on-realistic-ui-preview branch from 4919899 to 069d513 Compare August 26, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants