fix(devtools): QA feedbacks on the realistic UI preview - #1063
Open
harijoe wants to merge 11 commits into
Open
Conversation
Contributor
Greptile SummaryThe PR incorporates QA feedback for the realistic DevTools conversation preview.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains. No blocking failure remains. Reviews (2): Last reviewed commit: "revert(devtools): drop the skybridge ver..." | Re-trigger Greptile |
thleonard
approved these changes
Aug 26, 2026
… leaving fullscreen (SKY-557)
…p version (SKY-557)
…version in the header (SKY-557)
…gn the close button (SKY-557)
… button (SKY-557)
harijoe
force-pushed
the
julien/sky-557-qa-feedbacks-on-realistic-ui-preview
branch
from
August 26, 2026 16:04
4919899 to
069d513
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useRequestModalcan now be closed; before, nothing could dismiss it on either client.vite.config.tsfiles useimport.meta.dirname, dropping the config-loader warning new projects printed.Architecture Notes
openai.view, soisOpenflips from the store, not from the component.Alternatives Considered
closefromuseRequestModal— would let the view dismiss its own modal. No real host needs it: ChatGPT owns the chrome, and on an MCP Apps hostwindow.openaiis undefined so core's polyfill already closes itself. That would have added permanent v2 public API to paper over a DevTools-only gap.1.0.0and injects the real version at publish time, so in-repo runs always print it. Nothing to fix, and the header was the wrong home for it.