Skip to content

feat(devtools): read-only display mode and panel-bounded fullscreen (SKY-536) - #1048

Merged
harijoe merged 1 commit into
mainfrom
julien/sky-536-panel-read-only-display-mode-and-bounded-fullscreen
Aug 7, 2026
Merged

feat(devtools): read-only display mode and panel-bounded fullscreen (SKY-536)#1048
harijoe merged 1 commit into
mainfrom
julien/sky-536-panel-read-only-display-mode-and-bounded-fullscreen

Conversation

@harijoe

@harijoe harijoe commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Stacked on #1044 (SKY-535). Review only the last commit.

What

The display mode stops being user-controlled in the tool panel: it is driven only by the view.

  • The inline/pip/fullscreen buttons are replaced by a static badge showing the current mode (muted fill, no border, tooltip). The mode changes only when the widget requests it via requestDisplayMode / ui/request-display-mode.
  • displayMode is removed from the devtools_set_view_options WebMCP form, so agents can't set it either. The chatgpt-app-builder skill reference is updated to match.
  • Fullscreen is bounded to the tool panel work area instead of the whole devtools body: the ToolPanel root becomes the positioned ancestor of the fullscreen overlay, so the tools sidebar and header stay visible. The exit paths (cross button, ESC) are unchanged.
  • displayMode is no longer persisted (store version 2, migration drops it from v1 blobs). A stale persisted fullscreen would otherwise reopen the panel in fullscreen with no control left to explain or undo it; now every session starts inline and the view drives it from there.

@greptile-apps

greptile-apps Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR makes display mode view-controlled, removes it from persisted and WebMCP-configurable preferences, and bounds fullscreen rendering to the tool-panel workspace.

  • Replaces display-mode controls with a read-only status badge.
  • Migrates persisted preferences to omit display mode.
  • Makes the tool-panel root the fullscreen overlay’s positioned ancestor.
  • Updates the app-builder reference to match the revised WebMCP interface.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Reviews (5): Last reviewed commit: "feat(devtools): read-only display mode i..." | Re-trigger Greptile

Comment thread packages/devtools/src/components/layout/tool-panel/index.tsx
@harijoe

harijoe commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator Author

@greptileai

@qchuchu
qchuchu force-pushed the julien/sky-536-panel-read-only-display-mode-and-bounded-fullscreen branch from b7a7da9 to 0650829 Compare August 7, 2026 13:39
@harijoe
harijoe force-pushed the julien/sky-536-panel-read-only-display-mode-and-bounded-fullscreen branch from 0650829 to 3352874 Compare August 7, 2026 14:00
Base automatically changed from julien/sky-535-claude-skeleton-shell-and-client-switch to main August 7, 2026 14:39
@harijoe
harijoe force-pushed the julien/sky-536-panel-read-only-display-mode-and-bounded-fullscreen branch from 3352874 to 3d9f995 Compare August 7, 2026 14:39
@harijoe
harijoe merged commit 2bf54d8 into main Aug 7, 2026
19 checks passed
@harijoe
harijoe deleted the julien/sky-536-panel-read-only-display-mode-and-bounded-fullscreen branch August 7, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants