Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-govuk from 5.0.7 to 5.0.8 #1107

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Bump rubocop-govuk from 5.0.7 to 5.0.8 #1107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6abcd47
Bump rubocop-govuk from 5.0.7 to 5.0.8
dependabot[bot] Jan 21, 2025
7a4e2b4
Simplify boolean expression in problem_report.update
AgaDufrat Jan 29, 2025
653a8d2
Refactor to use update!
AgaDufrat Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ GEM
csv
mini_mime (>= 1.0.0)
multi_xml (>= 0.5.2)
i18n (1.14.6)
i18n (1.14.7)
concurrent-ruby (~> 1.0)
inflection (1.0.0)
io-console (0.8.0)
Expand Down Expand Up @@ -523,7 +523,7 @@ GEM
term-ansicolor (~> 1.7)
thor (>= 0.20, < 2.0)
parallel (1.26.3)
parser (3.3.6.0)
parser (3.3.7.0)
ast (~> 2.4.1)
racc
parslet (2.0.0)
Expand Down Expand Up @@ -631,7 +631,7 @@ GEM
rspec-mocks (~> 3.13)
rspec-support (~> 3.13)
rspec-support (3.13.2)
rubocop (1.69.2)
rubocop (1.70.0)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
Expand All @@ -645,8 +645,8 @@ GEM
parser (>= 3.3.1.0)
rubocop-capybara (2.21.0)
rubocop (~> 1.41)
rubocop-govuk (5.0.7)
rubocop (= 1.69.2)
rubocop-govuk (5.0.8)
rubocop (= 1.70.0)
rubocop-ast (= 1.37.0)
rubocop-capybara (= 2.21.0)
rubocop-rails (= 2.28.0)
Expand Down Expand Up @@ -705,7 +705,7 @@ GEM
sync
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
unicode-display_width (3.1.3)
unicode-display_width (3.1.4)
unicode-emoji (~> 4.0, >= 4.0.4)
unicode-emoji (4.0.4)
uri (0.13.1)
Expand Down
8 changes: 2 additions & 6 deletions app/controllers/anonymous_feedback/problem_reports_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,9 @@ def mark_supplied_reports_as_reviewed_and_spam

review_attrs = { reviewed: true, marked_as_spam: }

if problem_report.update(review_attrs)
true
else
false
end
problem_report.update!(review_attrs)
end
rescue ActiveRecord::RecordNotFound
rescue ActiveRecord::RecordNotFound, ActiveRecord::RecordInvalid
false
end

Expand Down