Correct Lint/Void: Literal used in void context rubocop offence

app/controllers/anonymous_feedback/problem_reports_controller.rb:78:11: W: Lint/Void: Literal true used in void context. true ^^^^
alphagov · Jan 29, 2025 · 9cf43aa · 9cf43aa
1 parent 6abcd47
commit 9cf43aa
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/app/controllers/anonymous_feedback/problem_reports_controller.rb b/app/controllers/anonymous_feedback/problem_reports_controller.rb
@@ -74,11 +74,7 @@ def mark_supplied_reports_as_reviewed_and_spam
 
         review_attrs = { reviewed: true, marked_as_spam: }
 
-        if problem_report.update(review_attrs)
-          true
-        else
-          false
-        end
+        problem_report.update(review_attrs) ? true : false
       end
     rescue ActiveRecord::RecordNotFound
       false