Add feature flag to disable autocomplete #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevindew
reviewed
Jan 8, 2025
There was a problem hiding this comment.
Looks good to me, just a suggestion on a flip
By moving the env var to be only needed here we'll also want to change the suggestion in the docs on how this is configured so we don't have a variable of disableSearchAutocomplete anymore - as we won't need a global one - and can instead suggest just adding an env var to the Search API V2 definition.
This adds a feature flag to disable autocomplete in case of unforeseen problems by returning an empty set of completion results in the response. This is controlled by the env var `ENABLE_AUTOCOMPLETE`, and will allow us to consolidate the logic behind disabling autocomplete in a single place instead of having it scattered across several apps (as the component will not render completions if no results are returned).
kevindew
reviewed
Jan 9, 2025
kevindew
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a feature flag to disable autocomplete in case of unforeseen
problems by returning an empty set of completion results in the
response.
This is controlled by the env var
ENABLE_AUTOCOMPLETE, and will allowus to consolidate the logic behind disabling autocomplete in a single
place instead of having it scattered across several apps (as the
component will not render completions if no results are returned).