Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service and task to update autocomplete denylist #355

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

csutter
Copy link
Contributor

@csutter csutter commented Nov 28, 2024

The data file for the denylist is stored in a GCP Cloud Storage bucket rather than as configuration in the app itself, as the denylist may contain sensitive language. The plan is to potentially move this into a private gem in the future.

In the meantime, this adds a service class to handle the occasionally required task of purging and re-importing the denylist, as well as a Rake task to invoke it.

The data file for the denylist is stored in a GCP Cloud Storage bucket
rather than as configuration in the app itself, as the denylist may
contain sensitive language. The plan is to potentially move this into a
private gem in the future.

In the meantime, this adds a service class to handle the occasionally
required task of purging and re-importing the denylist, as well as a
Rake task to invoke it.
Copy link

@jackbot jackbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. The comment at the top of the file is really helpful!

@csutter csutter merged commit 1a7edf1 into main Nov 28, 2024
8 checks passed
@csutter csutter deleted the autocomplete-denylist-import branch November 28, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants