Sanitise filter parameter values #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We occasionally (mostly through pentests) get values for filters that contain random odd Unicode characters. Google's filter logic has failing validations in those cases, causing an error to be raised on the request. This adds basic, allowlist based sanitisation for all incoming filter values. We know that the values come from a limited character set anyway (slugs and UUIDs), as they are not direct user input. - Add value parameter sanitisation for filters - Remove existing escape logic in `FilterExpressionHelpers` (as there should never be any quotes or backslashes in the values to begin with, and we will now have removed them anyway)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We occasionally (mostly through pentests) get values for filters that contain random odd Unicode characters. Google's filter logic has failing validations in those cases, causing an error to be raised on the request.
This adds basic, allowlist based sanitisation for all incoming filter values. We know that the values come from a limited character set anyway (slugs and UUIDs), as they are not direct user input.
FilterExpressionHelpers(as there should never be any quotes or backslashes in the values to begin with, and we will now have removed them anyway)