Ignore empty filter params from Finder Frontend #346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finder Frontend's buggy filter query construction logic will send through empty query params for `part_of_taxonomy_tree` whenever a finder has a taxon facet and none have been selected by the user. This is difficult to fix upstream, and other clients may misbehave similarly in the future. This would otherwise be "fine", but when running behind an AWS API Gateway, these empty params are transformed from `part_of_taxonomy_tree[]` to `part_of_taxonomy_tree[]=`, causing Search API v2's Rails app to parse them as an empty string rather than nil, and we end up filtering for empty strings as taxon IDs (which matches no documents). - Remove blank filter params using a `present?` check as part of filter parsing
|
Not needed as we're not going to make this public for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finder Frontend's buggy filter query construction logic will send through empty query params for
part_of_taxonomy_treewhenever a finder has a taxon facet and none have been selected by the user. This is difficult to fix upstream, and other clients may misbehave similarly in the future.This would otherwise be "fine", but when running behind an AWS API Gateway, these empty params are transformed from
part_of_taxonomy_tree[]topart_of_taxonomy_tree[]=, causing Search API v2's Rails app to parse them as an empty string rather than nil, and we end up filtering for empty strings as taxon IDs (which matches no documents).present?check as part of filter parsing