-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autocomplete API #317
Merged
Add autocomplete API #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b226050
to
386a573
Compare
kevindew
reviewed
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a few minor things.
4a6f4a4
to
c493922
Compare
kevindew
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just the README thing remains - but that needn't block this being merged.
Adds an API endpoint (`/autocomplete.json`) to return results for an autocomplete component we are currently building. This will return query suggestions for the user as they type, using the Discovery Engine `CompletionService` API. - Add controller/route/request spec for API endpoint and basic ActiveModel data class for result along the lines of existing search API - Add `DiscoveryEngine::Autocomplete::Complete` library to interact with Discovery Engine autocomplete feature - Add Rails configuration for (existing) `DISCOVERY_ENGINE_DATASTORE` environment variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an API endpoint (
/autocomplete.json
) to return results for an autocomplete component we are currently building. This will return query suggestions for the user as they type, using the Discovery EngineCompletionService
API.DiscoveryEngine::Autocomplete::Complete
library to interact with Discovery Engine autocomplete featureDISCOVERY_ENGINE_DATASTORE
environment variable