Implement retrying for transient DE errors #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On occasion, we will experience transient errors from Discovery Engine that will resolve themselves if we wait briefly and try again. In particular, this can happen when a number of updates come through in quick succession for the same document that are handled by different workers. - Add ability for put/delete operations to try for up to three attempts when an error occurs before giving up
kevindew
reviewed
Aug 13, 2024
- Extract shared context and examples from tests - Simplify `subject` logic in one place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On occasion, we will experience transient errors from Discovery Engine that will resolve themselves if we wait briefly and try again. In particular, this can happen when a number of updates come through in quick succession for the same document that are handled by different workers.