Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search quality monitoring #310

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Improve search quality monitoring #310

merged 2 commits into from
Aug 5, 2024

Conversation

csutter
Copy link
Contributor

@csutter csutter commented Aug 5, 2024

Two small changes to improve our quality monitoring ("judgement lists"):

csutter added 2 commits August 5, 2024 10:03
Now that we're setting up "proper" alerting for these, there is no
longer a need to indiscriminately chuck these into Sentry (the new flow
has AlertManager alerts linking through to Kibana where this information
is better presented).
This will allow us to show a user-friendly summary of absolute failure
numbers (instead of just relative) as part of alerts to give users
better situational awareness.
Copy link
Member

@kevindew kevindew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me, don't quite understand all that is going on but I don't think I need to.

@csutter
Copy link
Contributor Author

csutter commented Aug 5, 2024

code looks good to me, don't quite understand all that is going on but I don't think I need to.

Eventually I'd like to clean this up a bit as it's somewhat MVP, but on the other hand we're considering moving this all into Search Admin. Still a bit up in the air 🙂

@csutter csutter merged commit b0cf6fa into main Aug 5, 2024
8 checks passed
@csutter csutter deleted the more-quality-reporting branch August 5, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants