Turn attachments into parts
#176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a document has "attachments" in Publishing API, these should come through in search as if they were parts (even though they're technically not). This is a bit of a fudge from v1, but we have no choice but to replicate it to keep compatibility and desired functionality. Unfortunately the message from Publishing API doesn't include the content of the attachment, so depending on whether we consider that necessary, we may have to go out to Publishing API and fetch content to populate the `body` field of generated attachment parts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a document has "attachments" in Publishing API, these should come through in search as if they were parts (even though they're technically not). This is a bit of a fudge from v1, but we have no choice but to replicate it to keep compatibility and desired functionality.
Unfortunately the message from Publishing API doesn't include the content of the attachment, so depending on whether we consider that necessary, we may have to go out to Publishing API and fetch content to populate the
bodyfield of generated attachment parts.