Merge pull request #181 from alphagov/revert-180-metrics

Revert "Add initial metrics support"
alphagov · Jan 16, 2024 · a6f55a9 · a6f55a9
2 parents 1c68ee0 + fb64b66
commit a6f55a9
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 36 deletions.
diff --git a/app/services/discovery_engine/query/search.rb b/app/services/discovery_engine/query/search.rb
@@ -29,10 +29,7 @@ def result_set
     attr_reader :query_params, :client
 
     def response
-      @response ||= begin
-        Metrics.increment_counter(:search_requests)
-        client.search(discovery_engine_params).response
-      end
+      @response ||= client.search(discovery_engine_params).response
     end
 
     def discovery_engine_params

diff --git a/app/services/discovery_engine/sync/delete.rb b/app/services/discovery_engine/sync/delete.rb
@@ -11,7 +11,6 @@ def call(content_id, payload_version: nil)
       client.delete_document(name: document_name(content_id))
 
       log(Logger::Severity::INFO, "Successfully deleted", content_id:, payload_version:)
-      Metrics.increment_counter(:delete_requests)
     rescue Google::Cloud::NotFoundError => e
       log(
         Logger::Severity::INFO,
@@ -25,7 +24,6 @@ def call(content_id, payload_version: nil)
         content_id:, payload_version:,
       )
       GovukError.notify(e)
-      Metrics.increment_counter(:failed_delete_requests)
     end
 
   private

diff --git a/app/services/discovery_engine/sync/put.rb b/app/services/discovery_engine/sync/put.rb
@@ -25,15 +25,13 @@ def call(content_id, metadata, content: "", payload_version: nil)
       )
 
       log(Logger::Severity::INFO, "Successfully added/updated", content_id:, payload_version:)
-      Metrics.increment_counter(:put_requests)
     rescue Google::Cloud::Error => e
       log(
         Logger::Severity::ERROR,
         "Failed to add/update document due to an error (#{e.message})",
         content_id:, payload_version:,
       )
       GovukError.notify(e)
-      Metrics.increment_counter(:failed_put_requests)
     end
 
   private

diff --git a/app/services/metrics.rb b/app/services/metrics.rb