Skip to content

Make serving config optionally dynamic #842

Make serving config optionally dynamic

Make serving config optionally dynamic #842

Triggered via pull request February 7, 2025 16:06
Status Failure
Total duration 1m 18s
Artifacts 1

ci.yml

on: pull_request
CodeQL SAST scan  /  Analyze
1m 7s
CodeQL SAST scan / Analyze
Dependency Review scan  /  dependency-review-pr
4s
Dependency Review scan / dependency-review-pr
Dependency Review scan  /  dependency-review-push
0s
Dependency Review scan / dependency-review-push
Lint Ruby  /  Run RuboCop
15s
Lint Ruby / Run RuboCop
Security Analysis  /  Run Brakeman
30s
Security Analysis / Run Brakeman
Test Ruby
26s
Test Ruby
Fit to window
Zoom out
Zoom in

Annotations

3 errors
Lint Ruby / Run RuboCop: app/services/discovery_engine/query/search.rb#L59
Rails/Blank: Use `if query_params[:serving_config].blank?` instead of `unless query_params[:serving_config].present?`.
Lint Ruby / Run RuboCop: spec/services/discovery_engine/query/search_spec.rb#L213
Style/TrailingCommaInArguments: Put a comma after the last parameter of a multiline method call. (https://rubystyle.guide#no-trailing-params-comma)
Lint Ruby / Run RuboCop
Process completed with exit code 1.

Artifacts

Produced during runtime
Name Size
brakeman-json
1.33 KB