BaseAPIClient: add request_session constructor argument
#255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for injecting an externally constructed/configured requests.Session object
|
This could do with a lightweight test in https://github.com/alphagov/notifications-python-client/blob/main/tests/notifications_python_client/test_base_api_client.py to validate that multiple instances of the client are sharing the same object |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does the pull request solve?
This allows a pre-constructed
requests.Sessionobject to be used by the api client, which is useful for some esoteric use cases.Checklist
CHANGELOG.mdnotifications_python_client/__init__.pynotifications-python-client/scripts/generate_docker_env.shnotifications-python-client/tox.iniCONTRIBUTING.md