Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang 11-15 CI by removing libstdc++-13 #791

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

bernhardmgruber
Copy link
Member

@bernhardmgruber bernhardmgruber commented Nov 13, 2023

The clang 11-15 CI jobs got broken because g++-13 was made the default compiler on the Ubuntu images, and older clang versions fail to compile libstdc++-13 in C++20 mode. See issue here: actions/runner-images#8659.

@bernhardmgruber bernhardmgruber force-pushed the clang10_drop branch 2 times, most recently from 3a10fd9 to 6fdd42f Compare November 13, 2023 15:58
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #791 (2872a22) into develop (bb9ae93) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #791   +/-   ##
========================================
  Coverage    98.79%   98.79%           
========================================
  Files           75       75           
  Lines         7310     7310           
========================================
  Hits          7222     7222           
  Misses          88       88           

@bernhardmgruber bernhardmgruber force-pushed the clang10_drop branch 2 times, most recently from 20d2796 to 190ad11 Compare November 14, 2023 09:32
@bernhardmgruber bernhardmgruber changed the title Fix clang CI 2 Fix clang CI by removing libstdc++-13 Nov 14, 2023
@bernhardmgruber bernhardmgruber force-pushed the clang10_drop branch 7 times, most recently from 48865e7 to 49458ee Compare November 14, 2023 10:22
@bernhardmgruber bernhardmgruber changed the title Fix clang CI by removing libstdc++-13 Fix clang 11-15 CI by removing libstdc++-13 Nov 14, 2023
@bernhardmgruber bernhardmgruber mentioned this pull request Nov 14, 2023
@bernhardmgruber bernhardmgruber force-pushed the clang10_drop branch 3 times, most recently from 59ab624 to 77a7c2f Compare November 14, 2023 11:10
This works around these clang versions failing to compile libstdc++ from
g++-13.
@bernhardmgruber bernhardmgruber marked this pull request as ready for review November 14, 2023 13:21
@bernhardmgruber bernhardmgruber merged commit 8b711eb into alpaka-group:develop Nov 14, 2023
32 of 35 checks passed
@bernhardmgruber bernhardmgruber deleted the clang10_drop branch November 14, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant