Complex config support: Implement Block.Merge(), improve string representation. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Value.String() method returns a string only, implemeting the fmt.Stringer
interface.
Previously, a string value `StringValue("test")` would print as:
`0 "test" 0 false`
With this change, it prints as:
`test`
Users of the package can use the new Value.IsString() method to check if a
value really is a string. This is clumsy, but in reality users will more likely
use Value.Interface() and a type switch.
This change also implements the fmt.GoStringer interface for the Value type.
With this, if the above string value is printed with `%#v`, it will produce:
`config.StringValue("test")`
Consider these test outputs to see how these changes improve the output:
config_test.go:397: block = config.Block{Key:"Plugin", Values:[]config.Value{config.StringValue("test")}, Children:[]config.Block(nil)}
config_test.go:400: block.Merge() = blocks differ: got {key:SomethingElse values:[test]}, want {key:Plugin, values:[test]}, want error false
config_test.go:407: other block = config.Block{Key:"SomethingElse", Values:[]config.Value{config.StringValue("test")}, Children:[]config.Block(nil)}
…ock. I think this was a left-over from the original approach that unmarshalled before calling the callback.
wrap_configure_callback() needs to be able to modify the structs stored in that map. The most intuitive way to do that is by storing pointers in the map.
|
Sorry for trespassing – I got carried away since this was so close ;) I tested this with collectd/go-plugins#1 and it appears to work \o/ |
|
Haha, can't really trespass on your own project :). I've read through the code but there's nothing I could suggest to improve, looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
IsString()method is identical to"collectd.org/meta".Entry.IsString.Block.Merge()is going to be needed by thepluginpackage.