Skip to content

cli should accept files in different directory.#118

Open
alinbsp wants to merge 1 commit intoalongubkin:masterfrom
alinbsp:directory_arg
Open

cli should accept files in different directory.#118
alinbsp wants to merge 1 commit intoalongubkin:masterfrom
alinbsp:directory_arg

Conversation

@alinbsp
Copy link
Copy Markdown

@alinbsp alinbsp commented Dec 5, 2014

Hi,
Is there a reason for using the basename instead of the full file name here?

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling a41b60b on alinbsp:directory_arg into d501b66 on alongubkin:master.

@Namek
Copy link
Copy Markdown
Collaborator

Namek commented Dec 6, 2014

@alinbsp How does it affect the way it works?

@alongubkin
Copy link
Copy Markdown
Owner

Is there a reason for using the basename instead of the full file name here?

Yes - source maps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants