Skip to content

feat: demonstrate consensus x rpc types unification #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 15, 2025
Merged

feat: demonstrate consensus x rpc types unification #211

merged 6 commits into from
Apr 15, 2025

Conversation

yash-atreya
Copy link
Member

@yash-atreya yash-atreya commented Apr 14, 2025 •
edited
Loading

Motivation

Explain using a provider requests how the Consensus types are embedded into RPC types.

Solution

Demonstrate and explain using the following methods:

  • get_block
  • get_transaction_by_hash
  • get_transaction_receipt

PR Checklist

  • Added Documentation
  • Breaking changes

@yash-atreya yash-atreya requested a review from zerosnacks as a code owner April 14, 2025 07:55
@github-project-automation github-project-automation bot moved this to Reviewed in Alloy Apr 14, 2025
jenpaff
jenpaff approved these changes Apr 15, 2025
View reviewed changes
Copy link

@jenpaff jenpaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments on highlighting the impact a bit more otherwise lgtm

mattsse
mattsse approved these changes Apr 15, 2025
View reviewed changes
@yash-atreya yash-atreya merged commit c05b8de into main Apr 15, 2025
2 of 4 checks passed
@github-project-automation github-project-automation bot moved this from Reviewed to Done in Alloy Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenpaff jenpaff jenpaff approved these changes

@mattsse mattsse mattsse approved these changes

@zerosnacks zerosnacks zerosnacks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Alloy
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yash-atreya @jenpaff @mattsse @zerosnacks