Skip to content

Add properties param to notion_create_page/notion_update_page for real DB column support #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allocsys merged 3 commits into from
Jul 27, 2026
Merged

Add properties param to notion_create_page/notion_update_page for real DB column support #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
266592a
Add properties param to notion_create_page/notion_update_page for rea…
allocsys Jul 26, 2026
50069d3
Update top-level tool descriptions to mention real database property …
allocsys Jul 26, 2026
27dffd7
Document owner->all remapping for org repos in list_repos' type param
allocsys Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion connectors/github/repo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export function register(server) {
"List repositories for a GitHub user or organization.",
{
owner: z.string().describe("GitHub username or organization name"),
type: z.enum(["all", "owner", "member"]).optional().describe("Filter by repo type (default: all)"),
type: z.enum(["all", "owner", "member"]).optional().describe("Filter by repo type (default: all). Only meaningful for a user owner -- \"owner\" isn't a valid filter on GitHub's org-repos endpoint, so if `owner` turns out to be an organization, this is silently remapped to \"all\" rather than erroring."),
sort: z.enum(["created", "updated", "pushed", "full_name"]).optional().describe("Sort order (default: updated)"),
per_page: z.number().optional().describe("Number of repos to return, max 100 (default: 30)"),
},
Expand Down
44 changes: 27 additions & 17 deletions connectors/notion/tools.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
buildRelationBlocks, parseRelationBlocks,
buildSyncStartText, buildSyncRangeBlocks, findSyncRange, textBlock,
} from "./client.js";
import { findLinkCandidates, extractTags, findTagOverlapCandidates } from "./linking.js";

Check warning on line 14 in connectors/notion/tools.js

View workflow job for this annotation

GitHub Actions / test 

'findTagOverlapCandidates' is defined but never used

Check warning on line 14 in connectors/notion/tools.js

View workflow job for this annotation

GitHub Actions / test 

'findTagOverlapCandidates' is defined but never used

const STATUS_VALUES = ["open", "resolved", "superseded"];

Expand Down Expand Up @@ -124,7 +124,7 @@
// to track a thing that should be tracked -- so that case now throws
// instead of silently creating an untracked page. Passing one_off: true is
// the deliberate opt-out for real one-offs.
export async function doCreatePage({ parent_id, parent_type, title, content, entity_id, status, relations, one_off }) {
export async function doCreatePage({ parent_id, parent_type, title, content, entity_id, status, relations, one_off, properties }) {
if (!entity_id && !one_off) {
throw new Error(`Refusing to create "${title}" without a tracking decision -- pass either entity_id (if this represents an ongoing/stable thing that should be deduped and indexed) or one_off: true (if it's genuinely disposable, e.g. a scratch note or test page). This is a deliberate choice, not a bug -- see notion_create_page's entity_id and one_off param descriptions.`);
}
Expand Down Expand Up @@ -153,9 +153,9 @@
.map((c) => ({ to_entity_id: c.entity_id, relation: "relates_to" }));
const mergedRelations = [...explicitRelations, ...autoRelations];

const parent = parent_type === "database" ? { database_id: parent_id } : { page_id: parent_id };
const properties = parent_type === "database"
? { Name: { title: [{ text: { content: title } }] } }
const parent = parent_type === "database" ? { database_id: parent_id } : { page_id: parent_id };
const pageProperties = parent_type === "database"
? { Name: { title: [{ text: { content: title } }] }, ...(properties || {}) }
: { title: { title: [{ text: { content: title } }] } };
const markerBlocks = buildMarkerBlocks({ entity_id, status });
const relationBlocks = buildRelationBlocks(mergedRelations);
Expand All @@ -178,7 +178,7 @@
}
const data = await notionRequest("/pages", {
method: "POST",
body: { parent, properties, children: firstBatch },
body: { parent, properties: pageProperties, children: firstBatch },
});

// If a later batch fails (rate limit, network blip), the page ITSELF
Expand Down Expand Up @@ -323,16 +323,19 @@
// unsupported block type) -- the single-item tool catches this to preserve
// its existing isError response shape; the batch tool lets Promise.allSettled
// catch it per item, same pattern as mem/tools.js.
export async function doUpdatePage({ page_id, title, append_content, archived, replacements, status, relations }) {
export async function doUpdatePage({ page_id, title, append_content, archived, replacements, status, relations, properties }) {
const results = [];
// Unarchive (or a title-only change) runs first, same as before -- this
// leaves the page editable for any block-level edits below. Archiving
// (archived: true) is deliberately NOT handled here -- see the bottom of
// this function for why it's deferred to run last.
if (title !== undefined || archived === false) {
if (title !== undefined || archived === false || (properties !== undefined && archived !== true)) {
const body = {};
if (archived !== undefined) body.archived = archived;
if (title !== undefined) body.properties = { title: { title: [{ text: { content: title } }] } };
const propUpdates = {};
if (title !== undefined) propUpdates.title = { title: [{ text: { content: title } }] };
if (properties !== undefined) Object.assign(propUpdates, properties);
if (Object.keys(propUpdates).length) body.properties = propUpdates;
const data = await notionRequest(`/pages/${page_id}`, { method: "PATCH", body });
results.push(`Updated page "${notionPageTitle(data)}" (ID: ${data.id}).`);
}
Expand Down Expand Up @@ -406,7 +409,10 @@
// call with {title, archived: true} still sets both in one PATCH.
if (archived === true) {
const body = { archived: true };
if (title !== undefined) body.properties = { title: { title: [{ text: { content: title } }] } };
const propUpdates = {};
if (title !== undefined) propUpdates.title = { title: [{ text: { content: title } }] };
if (properties !== undefined) Object.assign(propUpdates, properties);
if (Object.keys(propUpdates).length) body.properties = propUpdates;
const data = await notionRequest(`/pages/${page_id}`, { method: "PATCH", body });
results.push(`Updated page "${notionPageTitle(data)}" (ID: ${data.id}).`);
}
Expand Down Expand Up @@ -561,7 +567,7 @@

server.tool(
"notion_create_page",
"Create a new Notion page inside a parent page or database. Pass entity_id to get upsert-style dedup protection (mirrors mem0_add): if a page already carries that entity_id marker, this refuses to create a duplicate and returns the existing page instead. Recommended whenever this page represents a stable, ongoing thing (a tracked PR, an issue, a recurring report) rather than a genuine one-off.",
"Create a new Notion page inside a parent page or database. Pass entity_id to get upsert-style dedup protection (mirrors mem0_add): if a page already carries that entity_id marker, this refuses to create a duplicate and returns the existing page instead. Recommended whenever this page represents a stable, ongoing thing (a tracked PR, an issue, a recurring report) rather than a genuine one-off. When parent_type is 'database', pass `properties` to set real database column values (select/rich_text/url/etc) -- see notion_get_database first for the schema.",
{
parent_id: z.string().describe("ID of the parent page or database"),
parent_type: z.enum(["page", "database"]).describe("Whether the parent is a page or a database"),
Expand All @@ -574,11 +580,12 @@
relation: z.string().describe("The relation type, e.g. 'blocks', 'depends_on', 'relates_to' -- free text"),
})).optional().describe("Optional list of outgoing relations from this page's entity to others, e.g. [{to_entity_id:'bug-4', relation:'blocks'}]. Stored as visible '🔗 relation -> to_entity_id' marker paragraphs. Only outgoing relations are supported -- see notion_get_page's Relations section for resolved targets."),
one_off: z.boolean().optional().describe("Set true to explicitly opt this page OUT of entity_id tracking -- required if entity_id is omitted. This tool refuses to create a page without either entity_id or one_off: true, so omitting entity_id by accident (rather than on purpose) is caught immediately instead of silently producing an untracked, un-deduped page. Use for genuine one-offs: scratch notes, test pages, throwaway content that will never need dedup or update-in-place."),
properties: z.record(z.any()).optional().describe("Optional Notion database property VALUES to set when parent_type is 'database' (ignored for parent_type 'page', which has no custom properties). Keys are property names exactly as they appear in the database schema; values must be in Notion's property-value format, e.g. { \"Status\": { \"select\": { \"name\": \"open\" } }, \"Apply Link\": { \"url\": \"https://...\" }, \"Comp / Rate\": { \"rich_text\": [{ \"text\": { \"content\": \"$10-60/hr\" } }] } }. Call notion_get_database first to see available property names and types."),
},
async ({ parent_id, parent_type, title, content, entity_id, status, relations, one_off }) => {
async ({ parent_id, parent_type, title, content, entity_id, status, relations, one_off, properties }) => {
let result;
try {
result = await doCreatePage({ parent_id, parent_type, title, content, entity_id, status, relations, one_off });
result = await doCreatePage({ parent_id, parent_type, title, content, entity_id, status, relations, one_off, properties });
} catch (err) {
return { content: [{ type: "text", text: err.message }], isError: true };
}
Expand Down Expand Up @@ -613,7 +620,7 @@

server.tool(
"notion_create_pages_batch",
"Create multiple Notion pages in a single call, to reduce round trips. Each item is created independently -- entity_id dedup, marker blocks, and dedup-index recording all apply per item exactly as in notion_create_page. One item failing (e.g. bad parent_id) does not block the others.",
"Create multiple Notion pages in a single call, to reduce round trips. Each item is created independently -- entity_id dedup, marker blocks, dedup-index recording, and database `properties` all apply per item exactly as in notion_create_page. One item failing (e.g. bad parent_id) does not block the others.",
{
items: z.array(z.object({
parent_id: z.string().describe("ID of the parent page or database"),
Expand All @@ -627,6 +634,7 @@
relation: z.string().describe("The relation type -- see notion_create_page"),
})).optional().describe("Optional outgoing relations for this page -- see notion_create_page."),
one_off: z.boolean().optional().describe("Required if entity_id is omitted -- see notion_create_page."),
properties: z.record(z.any()).optional().describe("Optional database property values for this page -- see notion_create_page."),
})).min(1).describe("List of pages to create"),
},
async ({ items }) => {
Expand Down Expand Up @@ -736,7 +744,7 @@

server.tool(
"notion_update_page",
"Update a Notion page's title or properties, append text content to it, make a targeted in-place edit to an existing block (replacements), or change its lifecycle status marker.",
"Update a Notion page's title, append text content to it, make a targeted in-place edit to an existing block (replacements), change its lifecycle status marker, or set real database column values via `properties` (select/rich_text/url/etc, if this page is a row in a database).",
{
page_id: z.string().describe("Notion page ID to update"),
title: z.string().optional().describe("New title for the page"),
Expand All @@ -751,10 +759,11 @@
to_entity_id: z.string().describe("The entity_id of the other entity this one relates to"),
relation: z.string().describe("The relation type, e.g. 'blocks', 'depends_on', 'relates_to' -- free text"),
})).optional().describe("New outgoing relations for this page -- REPLACES the existing relation set whole (not merged). Omit to leave relations unchanged. Pass an empty array to clear all relations."),
properties: z.record(z.any()).optional().describe("Database property VALUES to set/update on this page (only meaningful if the page is a row in a database). Keys are property names exactly as they appear in the database schema; values must be in Notion's property-value format, e.g. { \"Status\": { \"select\": { \"name\": \"resolved\" } } }. Merged with any title change into a single PATCH. Call notion_get_database first to see available property names and types."),
},
async ({ page_id, title, append_content, archived, replacements, status, relations }) => {
async ({ page_id, title, append_content, archived, replacements, status, relations, properties }) => {
try {
const results = await doUpdatePage({ page_id, title, append_content, archived, replacements, status, relations });
const results = await doUpdatePage({ page_id, title, append_content, archived, replacements, status, relations, properties });
return { content: [{ type: "text", text: results.join("\n") || "No changes made." }] };
} catch (err) {
return { content: [{ type: "text", text: err.message }], isError: true };
Expand Down Expand Up @@ -811,7 +820,7 @@

server.tool(
"notion_update_pages_batch",
"Update multiple Notion pages in a single call, to reduce round trips. Each item supports the same title/append_content/archived/replacements/status behavior as notion_update_page. One item failing (e.g. an ambiguous replacement match) does not block the others.",
"Update multiple Notion pages in a single call, to reduce round trips. Each item supports the same title/append_content/archived/replacements/status/properties behavior as notion_update_page. One item failing (e.g. an ambiguous replacement match) does not block the others.",
{
items: z.array(z.object({
page_id: z.string().describe("Notion page ID to update"),
Expand All @@ -827,6 +836,7 @@
to_entity_id: z.string().describe("The entity_id of the other entity this one relates to"),
relation: z.string().describe("The relation type -- see notion_update_page"),
})).optional().describe("New outgoing relations for this page -- see notion_update_page (whole-set replace)."),
properties: z.record(z.any()).optional().describe("Database property values to set/update on this page -- see notion_update_page."),
})).min(1).describe("List of page updates to apply"),
},
async ({ items }) => {
Expand Down
Loading