Remove generate-lockfile.yml (sandbox workaround, not needed) - #10
Merged
Conversation
…box's lack of network access, not a real ongoing need. Lockfile can be regenerated locally with a plain npm install when dependencies change.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
allocsys
added a commit
that referenced
this pull request
Jul 26, 2026
The prior version (removed in PR #10) pushed the regenerated lockfile straight to main via GITHUB_TOKEN, which doesn't trigger other workflows -- so its own commits never got the required "test" check and were likely to be blocked by the branch ruleset. This version opens a PR instead (via peter-evans/create-pull-request), so normal push/pull_request CI runs on it like any other change. See Notion: madmcp-delegate-gemini-resume-fix-plan page's sibling context and PR #10 for background.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes generate-lockfile.yml. It was a workaround for the dev sandbox having no network access to run npm install directly — not a real ongoing project need. It also has a structural problem: it pushes to main using the built-in GITHUB_TOKEN, and token-triggered pushes don't fire other workflows, so the new branch ruleset's required "test" check never runs on those commits — meaning the bot's own pushes are likely to get blocked going forward.
Going forward, regenerate package-lock.json locally with a plain
npm installwhen dependencies change, and commit it normally (as a PR, so CI runs and the ruleset is happy).Related: CI/CD Plan — madmcp