Skip to content

Issue-126: Hoist Node Dependencies and Dev Dependencies to Root #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

benpbolton
Copy link
Contributor

@benpbolton benpbolton commented Apr 16, 2025

Summary

Fixes #126

This pull request addresses the issue of hoisting Node dependencies and devDependencies to the root of the repository when using Turbo. The goal is to ensure that after running the configure script, all dependencies and devDependencies are extracted and centralized within the root package.json. Additionally, workflow improvements have been made to start testing node.

Changes

  • Updated the configure script to include new functions for:
    • Extracting dependencies, devDependencies from create-wordpress-plugin and create-wordpress-theme package.json files.
    • Merging the extracted dependencies into the root package.json, ensuring no duplicates and maintaining alphabetical order and latest versions.
  • Introduced the use of alleyinteractive/action-test-general@develop and alleyinteractive/action-test-node for broader test coverage.
  • Broke out the Composer install/make step from the (eventual) test. composer test currently disabled due to an unrelated issue)

How to Test

  1. Run the configure script.
  2. Verify that the root package.json contains a comprehensive, alphabetically sorted list of dependencies and devDependencies.
  3. Workflow updates for testing are functional and correctly integrated.

Additional Information

Refer to the original issue #126 for further context.

@benpbolton benpbolton added ci/cd PR checks, deploys, automation javascript Requires understanding JavaScript enhancement New feature or request labels Apr 16, 2025
@benpbolton benpbolton marked this pull request as ready for review April 16, 2025 18:45
@benpbolton benpbolton requested a review from a team as a code owner April 16, 2025 18:45
Copy link
Contributor

@mogmarsh mogmarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good except for a few PHP = alignments (welcome to WordPress world @benpbolton)

@benpbolton benpbolton merged commit 21c7eb6 into production Apr 21, 2025
1 check passed
@benpbolton benpbolton deleted the feature/issue-126/hoist-node-dependencies-to-root branch April 21, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd PR checks, deploys, automation enhancement New feature or request javascript Requires understanding JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hoist Node Dependencies and Dev Dependencies to Root
2 participants