Open
Conversation
fix(_vector_ds) Removed assert that hangs in some cases feat(TODO) added todo for removing gen.Task
perimosocordiae
requested changes
Sep 23, 2019
| PrimaryKeyMetadata, NumericMetadata, BooleanMetadata, LookupMetadata) | ||
| UploadedSpectrumDataset, | ||
| WebTrajDataset, WebVectorDataset, WebLIBSDataset, DATASETS, | ||
| PrimaryKeyMetadata, NumericMetadata, BooleanMetadata, LookupMetadata) |
Member
There was a problem hiding this comment.
Hanging indents (like these and the other instances in this file) should stay at 4 spaces.
|
|
||
| resample = (self.get_argument('lb', ''), self.get_argument('ub', ''), | ||
| self.get_argument('step', '')) | ||
| resample = (self.get_argument('lb', ''), self.get_argument('ub', ''), self.get_argument('step', '')) |
Member
There was a problem hiding this comment.
What's your column wrapping set to? I prefer to keep lines under 80 characters.
| order[data_order[meta_order]] = np.arange(len(order)) | ||
| data = data[order] | ||
| assert np.array_equal(meta_pkeys, pkey[order]) | ||
| # assert np.array_equal(meta_pkeys, pkey[order]) # Causes it to silently fail in some cases |
Member
There was a problem hiding this comment.
I think we should keep the check, but instead of using assert it should return a 415 error with a useful message.
If these arrays aren't equal, it means that the spectra and their associated metadata are out of sync, and your uploaded dataset isn't going to be correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(backend/handlers/upload.py) use of visible_error where not defined/accessible
fix(backend/handlers/upload.py) Hanging on uploading data due to broken assert
Not sure as to why the assert breaks normal operation, but upon removing it our dataset uploaded as expected.