Remove duplicated groups for EP and DP_EP#226
Open
gabrielecastellano wants to merge 1 commit intoaliyun:masterfrom
Open
Remove duplicated groups for EP and DP_EP#226gabrielecastellano wants to merge 1 commit intoaliyun:masterfrom
gabrielecastellano wants to merge 1 commit intoaliyun:masterfrom
Conversation
This addresses the problem described in aliyun#222
There was a problem hiding this comment.
Pull request overview
This PR fixes a redundancy issue in MockNcclGroup constructor where EP and DP_EP communication groups were being created multiple times with identical configurations due to unused loop variables. As described in issue #222, the inner j loops iterated _EP_size and _DP_EP_size times respectively, but the j variable was never used in the loop body, resulting in the same groups being created and overwritten repeatedly in the GroupIndex map.
Changes:
- Removed the redundant inner
for(int j = 0; j < _EP_size; j++)loop from EP group creation, reducing unnecessary duplicate group construction - Removed the redundant inner
for(int j = 0; j < _DP_EP_size; j++)loop from DP_EP group creation - Added a trailing newline at the end of the file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the problem described in #222, where the
MockNcclGroupmethod unnecessarily creates_EP_sizetimes the sameEPgroups (and_DP_EP_sizetimes the sameDP_EPgroups).