Skip to content

Fix simulation hang when QP allocation in SendFlow produces 0-byte or mismatched-size QPs #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix simulation hang when QP allocation in SendFlow produces 0-byte or mismatched-size QPs #225

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a311a35
Initial plan
Copilot Mar 4, 2026
b12a40e
Fix SendFlow hang: skip 0-byte QPs and relax send-size check in notif…
Copilot Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions astra-sim-alibabacloud/astra-sim/network_frontend/ns3/entry.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,10 @@ void SendFlow(int src, int dst, uint64_t maxPacketCount,
for(int index = 0 ;index<_QPS_PER_CONNECTION_;index++){
uint64_t real_PacketCount = min(PacketCount,leftPacketCount);
leftPacketCount-=real_PacketCount;
if(real_PacketCount == 0) {
NcclLog->writeLog(NcclLogLevel::DEBUG," [SendFlow] skipping 0-byte QP index %d src %d dst %d flow_id %d",index,src,dst,request->flowTag.current_flow_id);
continue;
}
uint32_t port = portNumber[src][dst]++;
{
#ifdef NS3_MTP
Expand All @@ -137,7 +141,6 @@ void SendFlow(int src, int dst, uint64_t maxPacketCount,
}
send_lat *= 1000;
flow_input.idx++;
if(real_PacketCount == 0) real_PacketCount = 1;
MockNcclLog* NcclLog = MockNcclLog::getInstance();
NcclLog->writeLog(NcclLogLevel::DEBUG," [Packet sending event] %dSendFlow to %d channelid: %d flow_id %d srcip %d dstip %d size: %llu at the tick: %d",src,dst,tag,flow_id,serverAddress[src],serverAddress[dst],maxPacketCount,AstraSim::Sys::boostedTick());
NcclLog->writeLog(NcclLogLevel::DEBUG," request->flowTag [Packet sending event] %dSendFlow to %d tag_id: %d flow_id %d srcip %d dstip %d size: %llu at the tick: %d",request->flowTag.sender_node,request->flowTag.receiver_node,request->flowTag.tag_id,request->flowTag.current_flow_id,serverAddress[src],serverAddress[dst],maxPacketCount,AstraSim::Sys::boostedTick());
Expand Down Expand Up @@ -249,7 +252,7 @@ void notify_sender_sending_finished(int sender_node, int receiver_node,
task1 t2 = sentHash[make_pair(tag, make_pair(sender_node, receiver_node))];
AstraSim::SendPacketEventHandlerData* ehd = (AstraSim::SendPacketEventHandlerData*) t2.fun_arg;
ehd->flowTag=flowTag;
if (t2.count == message_size) {
if (message_size >= t2.count) {
sentHash.erase(make_pair(tag, make_pair(sender_node, receiver_node)));
if (nodeHash.find(make_pair(sender_node, 0)) == nodeHash.end()) {
nodeHash[make_pair(sender_node, 0)] = message_size;
Expand Down