Small improvements to e2e scripts #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luke-Sikina
commented
Apr 19, 2021
| @@ -0,0 +1,23 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Not sure what a lot of this logic does. Could be that a lot of this can be trimmed. All this is really doing is docker-compose down
alisman
reviewed
Apr 19, 2021
| fi | ||
|
|
||
|
|
||
| export PORTAL_SOURCE_DIR=$PWD; |
There was a problem hiding this comment.
how come we do all this in stop script?
There was a problem hiding this comment.
stop.sh calls cd $E2E_WORKSPACE/cbioportal-docker-compose before executing the docker commands
- change `sh` to `bash`, as not all shells are compatible with the `<<<` in the e2e scripts - added `e2e:spindown` command. It just runs `docker-compose down` - added some documentation on how to verify that the server is running - added logic to delete volume before building
alisman
pushed a commit
that referenced
this pull request
Jun 2, 2022
Put all NaN at end in clustering
alisman
pushed a commit
that referenced
this pull request
Jun 9, 2022
Put all NaN at end in clustering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shtobash, as not all shells are compatible with the<<<in the e2e scriptse2e:spindowncommand. It just runsdocker-compose down