add some basic structure for quantizer, io and simd operators #25

LHT129 · 2024-09-12T02:40:54Z

only header for quantizer and io
fp32 quantizer as example

inabao · 2024-09-12T03:01:15Z

src/io/memory_io.h

+
+private:
+    [[nodiscard]] inline bool
+    CheckValidOffset(uint64_t size) const {


unify the naming convention; our private methods generally use the underscore naming style. (check_valid_offset)

inabao · 2024-09-12T07:58:08Z

src/simd/fp32_simd_test.cpp

+#include "fixtures.h"
+using namespace vsag;
+
+#define TEST_RECALL(Func)                                                              \


Renaming it to TEST_ACCURACY would be more accurate.

inabao · 2024-09-12T07:59:55Z

src/simd/generic.cpp

+        auto val = query[i] - codes[i];
+        result += val * val;
+    }
+    return result;


There is no sqrt in the result. So, it is better to rename it to "FP32ComputeL2".

L2Sqr is the Square of L2 norm

inabao · 2024-09-12T08:02:50Z

src/quantization/quantizer.h

+private:
+    uint64_t dim_{0};
+
+    uint64_t codeSize_{0};


unify the code style.

codeSize -> code_size_

ShawnShawnYou · 2024-09-13T03:03:22Z

src/quantization/quantizer_test.h

+    auto* outVec = new float[dim];
+    quant.DecodeOne(codes, outVec);
+    for (int i = 0; i < dim; ++i) {
+        REQUIRE(std::abs(vecs[idx * dim + i] - outVec[i]) < error);


should replace abs with fabs?

For integral arguments, the integral overloads of std::abs are likely better matches.
reference: https://en.cppreference.com/w/cpp/numeric/math/fabs

ShawnShawnYou · 2024-09-13T03:10:59Z

src/simd/avx.cpp

+        sum = _mm256_add_ps(sum, _mm256_mul_ps(a, b));  // accumulate the product
+    }
+    alignas(32) float result[8];
+    _mm256_store_ps(result, sum);  // store the accumulated result into an array


When n == 0, the store instruction (e.g. _mm256_store_ps) still occur in the avx512, avx2, and sse operators that may be harmful to the performance. Is it possible to add a judgment to skip these store instructions?

yeah, I have fixed it

ShawnShawnYou · 2024-09-13T03:21:31Z

src/quantization/quantizer_test.h

+        } else if (metric == vsag::MetricType::METRIC_TYPE_L2SQR) {
+            gt = L2Sqr(data + idx1 * dim, query + i * dim, &dim);
+        }
+        REQUIRE(std::abs(gt - value) < 1e-4);


inabao

LGTM

Signed-off-by: LHT129 <[email protected]>

wxyucs

lgtm

jiaweizone · 2024-09-14T07:34:45Z

src/io/basic_io.h

+
+namespace vsag {
+
+template <typename IOTmpl>


IOTmpl need any interface limit ?

jiaweizone · 2024-09-14T07:44:41Z

src/io/memory_io.h

+    return ret;
+}
+void
+MemoryIO::PrefetchImpl(uint64_t offset, uint64_t cacheLine) {


explicit mark cacheLine to unused ?
cacheLine -> cache_line

jiaweizone · 2024-09-14T07:50:59Z

src/quantization/fp32_quantizer.h

+
+namespace vsag {
+
+template <MetricType Metric = MetricType::METRIC_TYPE_L2SQR>


Metric -> metric

jiaweizone · 2024-09-14T07:57:55Z

src/io/basic_io.h

+    }
+
+    inline void
+    Prefetch(uint64_t offset, uint64_t cacheLine = 64) {


cacheLine -> cache_line

jiaweizone · 2024-09-14T07:58:11Z

src/io/memory_io.h

+    MultiReadImpl(uint8_t* datas, uint64_t* sizes, uint64_t* offsets, uint64_t count) const;
+
+    inline void
+    PrefetchImpl(uint64_t offset, uint64_t cacheLine = 64);


cacheLine -> cache_line

jiaweizone · 2024-09-14T07:59:19Z

src/quantization/quantizer.h

+
+    uint64_t codeSize_{0};
+
+    bool isTrained_{false};


isTrained_ -> is_trained_

jiaweizone · 2024-09-14T07:59:36Z

src/quantization/quantizer.h

+private:
+    uint64_t dim_{0};
+
+    uint64_t codeSize_{0};


codeSize -> code_size_

jiaweizone · 2024-09-14T08:11:25Z

src/quantization/fp32_quantizer.h

+    } else if (Metric == MetricType::METRIC_TYPE_COSINE) {
+        return InnerProduct(codes1, codes2, &this->dim_);  // TODO
+    } else {
+        return 0.;


LHT129 force-pushed the lht_dev branch from d66c9db to d717176 Compare September 12, 2024 02:44

LHT129 requested review from jiaweizone, inabao, wxyucs and ShawnShawnYou September 12, 2024 02:51

LHT129 force-pushed the lht_dev branch 3 times, most recently from d41db02 to 36309db Compare September 12, 2024 03:42

inabao reviewed Sep 12, 2024

View reviewed changes

LHT129 force-pushed the lht_dev branch 2 times, most recently from f1ae5ea to ca3eda5 Compare September 12, 2024 09:36

LHT129 requested a review from inabao September 13, 2024 02:46

LHT129 force-pushed the lht_dev branch 2 times, most recently from eb24b83 to 414ce55 Compare September 13, 2024 02:59

ShawnShawnYou reviewed Sep 13, 2024

View reviewed changes

LHT129 force-pushed the lht_dev branch from 414ce55 to 4e1ffd3 Compare September 13, 2024 03:13

ShawnShawnYou reviewed Sep 13, 2024

View reviewed changes

LHT129 force-pushed the lht_dev branch 2 times, most recently from 60ae2ae to f421f5f Compare September 13, 2024 06:29

LHT129 requested a review from ShawnShawnYou September 13, 2024 06:45

LHT129 force-pushed the lht_dev branch from f421f5f to b610b7c Compare September 14, 2024 02:51

inabao approved these changes Sep 14, 2024

View reviewed changes

LHT129 force-pushed the lht_dev branch 6 times, most recently from 24002ac to d5e42ef Compare September 14, 2024 07:07

add some basic structure for quantizer, io and simd operators

0e8c538

Signed-off-by: LHT129 <[email protected]>

LHT129 force-pushed the lht_dev branch from d5e42ef to 0e8c538 Compare September 14, 2024 07:14

wxyucs approved these changes Sep 14, 2024

View reviewed changes

jiaweizone reviewed Sep 14, 2024

View reviewed changes

wxyucs added the kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) label Sep 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add some basic structure for quantizer, io and simd operators #25

add some basic structure for quantizer, io and simd operators #25

LHT129 commented Sep 12, 2024

inabao Sep 12, 2024

inabao Sep 12, 2024

LHT129 Sep 12, 2024

inabao Sep 12, 2024

LHT129 Sep 12, 2024

inabao Sep 12, 2024

jiaweizone Sep 14, 2024

ShawnShawnYou Sep 13, 2024

LHT129 Sep 13, 2024

ShawnShawnYou Sep 13, 2024

LHT129 Sep 13, 2024

ShawnShawnYou Sep 13, 2024

inabao left a comment

wxyucs left a comment

jiaweizone Sep 14, 2024

jiaweizone Sep 14, 2024

jiaweizone Sep 14, 2024

jiaweizone Sep 14, 2024

jiaweizone Sep 14, 2024

jiaweizone Sep 14, 2024

jiaweizone Sep 14, 2024

jiaweizone Sep 14, 2024


		namespace vsag {

		template <MetricType Metric = MetricType::METRIC_TYPE_L2SQR>

add some basic structure for quantizer, io and simd operators #25

Are you sure you want to change the base?

add some basic structure for quantizer, io and simd operators #25

Conversation

LHT129 commented Sep 12, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

inabao left a comment

Choose a reason for hiding this comment

wxyucs left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment