fix(utils): include query-params from base when building uri#123
Merged
aliev merged 1 commit intoaliev:masterfrom Aug 7, 2025
Merged
fix(utils): include query-params from base when building uri#123aliev merged 1 commit intoaliev:masterfrom
aliev merged 1 commit intoaliev:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello again!
I've been using v2 for quite some time now and really enjoying it. Our OAuth server implemented with it is working fantastically! However, I ran into a small issue when attempting to integrate with a wordpress site using an older plugin called "OpenID Connect Client".
The plugin uses a redirect-uri with a configured query-parameter that is essential for the plugin:
.../wp-admin/admin-ajax.php?action=openid-connect-authorize. If the action parameter is missing, the redirect just errors with wordpress seemingly unsure what to do with the request, and the login fails.It turns out aioauth is stripping query-parameters from the configured redirect-uri and just replacing them with the response parameters on response, so this just ensures that the base parameters are included but overwritten by the response ones if required.
After the following changes, the login worked as intended.
Hope this helps, thanks :)