fix: improve exception logging and remove legacy classes - #15627
Open
lxcxjxhx wants to merge 4 commits into
Open
fix: improve exception logging and remove legacy classes#15627lxcxjxhx wants to merge 4 commits into
lxcxjxhx wants to merge 4 commits into
Conversation
- Add SLF4J logger to capture previously silent exceptions - Replace empty catch blocks with debug logging for better troubleshooting - Maintain backward compatibility with legacy protocol formats Local environment limitations: relying on CI/CD automated testing for full validation
Remove legacy protobuf classes GetRequest and Log that were used for 1.x to 2.x upgrade. Nacos is now at 3.x and no longer supports direct upgrade from 1.x. Changes: - Remove GetRequest and Log message definitions from Data.proto - Remove references from JRaftUtils.java - Remove class registrations from NacosRuntimeHints.java - Remove native-image initialization config from console/pom.xml Fixes alibaba#15608
|
Thanks for your this PR. 🙏 感谢您提交的PR。 🙏 |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The ProtoMessageUtil class had incomplete exception handling that could make debugging difficult. Additionally, legacy GetRequest and Log classes from 1.x upgrade compatibility were no longer needed and added unnecessary complexity.
Changes
ProtoMessageUtil Enhancement
Legacy Class Removal
Testing
Checklist