fix(manager): allow container API helpers in strict mode#190
Open
samzong wants to merge 1 commit intoalibaba:mainfrom
Open
fix(manager): allow container API helpers in strict mode#190samzong wants to merge 1 commit intoalibaba:mainfrom
samzong wants to merge 1 commit intoalibaba:mainfrom
Conversation
Author
|
@johnlanni it's seem not PR reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
manager/scripts/lib/container-api.shso_apiand_api_codecan be called without a request body when sourced from scripts running withset -u.Previously, calls like
_api GET /versionor_api_code POST /containers/<name>/startcould fail with an unbound variable error because$3was accessed directly.Fixes #188
Changes
dataargument in_apiand_api_codewith${3-}changelog/current.mdWhy
Several container API helpers intentionally omit the request body argument. That works in normal shell mode, but breaks in bash strict mode (
set -u), which some manager scripts use.Testing
bash manager/tests/test-container-api-strict-mode.shbash -n manager/scripts/lib/container-api.shbash -n manager/tests/test-container-api-strict-mode.shbash -n manager/agent/skills/worker-management/scripts/lifecycle-worker.sh