[rpc] Remove describeLakeStorage to get LakeStorageInfo from table properties #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteNicholas
force-pushed
the
FLUSS-411
branch
from
b9fa8a3 to
71497c2
Compare
SteNicholas
force-pushed
the
FLUSS-411
branch
from
71497c2 to
ef02fbb
Compare
SteNicholas
force-pushed
the
FLUSS-411
branch
3 times, most recently
from
f4e2326 to
7d39de6
Compare
luoyuxia
reviewed
Feb 28, 2025
There was a problem hiding this comment.
@SteNicholas Thanks for the pr. Left some comments..
Also, since the lake storage info can be retrieved from table, the LakeStorageInfo in LakeSnapshot can also be removed.
...nector-flink/src/main/java/com/alibaba/fluss/connector/flink/utils/LakeStorageInfoUtils.java
Outdated
Show resolved
Hide resolved
...nector-flink/src/main/java/com/alibaba/fluss/connector/flink/utils/LakeStorageInfoUtils.java
Outdated
Show resolved
Hide resolved
...ss-connector-flink/src/main/java/com/alibaba/fluss/connector/flink/catalog/FlinkCatalog.java
Show resolved
Hide resolved
wuchong
reviewed
Feb 28, 2025
fluss-rpc/src/main/java/com/alibaba/fluss/rpc/protocol/ApiKeys.java
Outdated
Show resolved
Hide resolved
...se-paimon/src/test/java/com/alibaba/fluss/lakehouse/paimon/testutils/PaimonSyncTestBase.java
Outdated
Show resolved
Hide resolved
...nector-flink/src/main/java/com/alibaba/fluss/connector/flink/utils/LakeStorageInfoUtils.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #411
LakeStorageInfois forwarded info to table properties in #362. Therefore,describeLakeStoragecould be removed sinceLakeStorageInfohas been in table properties.Brief change log
describeLakeStorageto getLakeStorageInfofrom table properties viaLakeStorageUtils#getLakeStorageInfo.lakeStorageInfoinLakeSnapshot.MetadataManager#getTable(TablePath tablePath)to fill inTableInfowith datalake properties.Tests
CI.
API and Format
Remove
Admin#describeLakeStorage.Documentation
No.