Init commit of Kafka protocol supporting #478
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dao-jun
changed the title
|
@wuchong PTAL |
|
@wuchong I've finished this PR, do you have any suggestions? or maybe we can merge the PR and push forward |
wuchong
reviewed
Mar 1, 2025
There was a problem hiding this comment.
Looks good in general. Could you set up the code format plugin in IDEA to automatically re-format to Google Java Style?
https://alibaba.github.io/fluss-docs/docs/dev/ide-setup/#code-formatting
| import static org.apache.kafka.common.protocol.ApiKeys.API_VERSIONS; | ||
| import static org.apache.kafka.common.protocol.ApiKeys.PRODUCE; | ||
|
|
||
| @Slf4j |
There was a problem hiding this comment.
We want to keep a minimal dependency footprint, let's avoid introducing Lombok and manually declare the Logger instead.
| @@ -0,0 +1,37 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #488
Purpose
Support Kafka Protocol
Tests
NONE