Fix convert.py: --global-index no longer requires --input-dir#28
Merged
Conversation
argparse validated --input-dir before the --global-index early-exit could fire, so the standalone mode always failed. Make --input-dir optional and add an explicit check for when neither flag is supplied. Fixes #24 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--input-dirwas declaredrequired=Truein argparse, so it was validated before the--global-indexearly-exit could firepython3 convert.py --global-index collections/always failed with a misleading argparse error--input-diroptional (required=False, defaultNone) and adds an explicitparser.error()when neither--global-indexnor--input-diris suppliedFixes #24
Test plan
python3 convert.py --global-index collections/— no longer fails with argparse errorpython3 convert.py(no args) — still fails with actionable error messagepython3 convert.py --input-dir collections/NAME/pdfs— normal conversion unaffected🤖 Generated with Claude Code