Skip to content

Conversation

@cce
Copy link
Contributor

@cce cce commented Jan 6, 2023

Summary

As described in #590 if you don't have any participation keys, you don't need to make a proposal. This adds a check to skip calling AssembleBlock() if there are no participating accounts.

Test Plan

Existing tests should pass, also need to write new test asserting AssembleBlock is not called.

@cce cce added the Enhancement label Jan 6, 2023
@cce cce requested a review from yossigi January 10, 2023 15:39
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Attention: Patch coverage is 39.13043% with 14 lines in your changes missing coverage. Please review.

Project coverage is 51.86%. Comparing base (64ae8b0) to head (75daeed).

Files with missing lines Patch % Lines
data/pools/transactionPool.go 0.00% 8 Missing ⚠️
agreement/pseudonode.go 0.00% 1 Missing and 1 partial ⚠️
components/mocks/mockParticipationRegistry.go 0.00% 2 Missing ⚠️
data/account/participationRegistry.go 80.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4976   +/-   ##
=======================================
  Coverage   51.86%   51.86%           
=======================================
  Files         653      653           
  Lines       87547    87559   +12     
=======================================
+ Hits        45408    45416    +8     
- Misses      39264    39272    +8     
+ Partials     2875     2871    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant