fix: redirect personal users to valid landing page after authentication#330
Open
iamraghs wants to merge 2 commits into
Open
fix: redirect personal users to valid landing page after authentication#330iamraghs wants to merge 2 commits into
iamraghs wants to merge 2 commits into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #329
After signing in with GitHub, users were being redirected to /home, which doesn't exist as a top-level route (it's only available under /:org_handle/home). This caused a 404 right after login.
While investigating, I also found that several other common URLs users might try were returning 404:
/home
/dashboard
/profile
/settings
/users/yourhandle
None of these had top-level routes, so I added them.
Changes
Post-login redirect — signed_in_path_from_context("personal") now redirects to / instead of /home. The root path is the actual homepage and works for everyone.
New route redirects for /home, /dashboard, /settings — these now redirect to existing pages that work (/, /, /user/settings).
New /profile route — checks if you're logged in and sends you to your profile page (e.g. /yourhandle/profile). If you're not logged in, it sends you to the login page.
New /users/:handle route — lets you visit someone's profile via /users/theirhandle (works the same as /theirhandle).
That covers everything reported in the issue.