Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile/list: show errors in table listing instead of failing #145

Merged
merged 3 commits into from
Mar 8, 2024
Merged

profile/list: show errors in table listing instead of failing #145

merged 3 commits into from
Mar 8, 2024

Conversation

dhowden
Copy link
Contributor

@dhowden dhowden commented Mar 5, 2024

Without annotation the error is not helpful when you have multiple profiles.

Note: this also uses the AdminAPIKey, which might need another change to amend.

Without annotation the error is not helpful when you have multiple profiles.

This also appears to require an AdminAPIKey, which might need another change to ammend.
@dhowden
Copy link
Contributor Author

dhowden commented Mar 5, 2024

FYI @helenamariano this from our conversation.

@clemfromspace
Copy link
Contributor

clemfromspace commented Mar 7, 2024

Thanks for the PR @dhowden 👍

What do you think about gracefully failing, like displaying the error for the profile in the NB OF INDICES column instead?
So we can, at the same time:

  • See all profiles for which the API credentials are correct (just display the number of indices)
  • See all profiles for which the API credentials are not correct (wrong AppID and/or APIKey)
  • See all profiles for which we are missing the listIndices ACL (? (APIKey without listIndices ACL))

I'm happy to take over the PR if you don't have the time, let me know :)

@dhowden
Copy link
Contributor Author

dhowden commented Mar 7, 2024

Hey @clemfromspace.

No worries, I've updated the change to put the error in the table as suggested. Happy for you to take it from here to get it over the line!

@dhowden dhowden changed the title profile/list: annotate error for easier debugging profile/list: show errors in table listing instead of failing Mar 7, 2024
Copy link
Contributor

@clemfromspace clemfromspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Thank you!

@clemfromspace clemfromspace merged commit f9157ba into algolia:main Mar 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants