Adding Film support to ForceVue #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All of my tests seem to be passing at this point; these other errors look to me like persistent issues rather than problems with my commit. I was interested to see the e2e output on CircleCI for the Firefox tests -- that's more or less exactly the error I was getting as well. |
|
You are correct @dimerization . There appears to be an issue with Firefox on the Circle CI build server. I will investigate that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are intended to close issue #9 .
One note: I was unable to get Selenium and Nightwatch to play nicely together and therefore could not verify that the e2e tests pass. That's why I created the first commit -- I wanted to move my changes to a Linux machine and see if I could get the e2e tests to run there (I couldn't). However, the unit tests pass and I have tested the code, and it works fine as far as I can tell. Obviously I would prefer to verify the e2e tests before committing the code, but I've hit a wall on my end so I'm submitting what I have. I look forward to seeing the results of the e2e tests and making any necessary changes to get them to pass.