Adds Vehicle support and images for views #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkramer
reviewed
Oct 25, 2016
| @@ -26,3 +27,33 @@ starship.fetch = id => { | |||
| }, reject); | |||
| }); | |||
| }; | |||
| starship.getPicture = searchWord => { | |||
There was a problem hiding this comment.
This picture search appears to be the exact same for each of the component API files. Would prefer moving this to a picture API file and delegating to that.
| }); | ||
| }, | ||
| }, | ||
| }; | ||
| </script> | ||
|
|
||
| <!-- Add "scoped" attribute to limit CSS to this component only --> | ||
| <style scoped> |
There was a problem hiding this comment.
This block is copied across the components. Would be a good candidate to push to a style file that can be imported into components that need it.
|
Looks pretty good! If possible see if you can add a small test of the new functionality you tested. I also realize that the tests are failing across the builds right now due to Firefox. Do not worry about that, I will take a look and see if I can fix that. |
added 7 commits
October 25, 2016 10:56
(not the original issue I was working on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues #51 and #7