Offline docs extension - #130
Open
brukberhane wants to merge 10 commits into
Open
Conversation
Author
|
There is still some issues with the offline extension not being loaded correctly when packaged |
Author
|
This should resolve the offline directories for MacOS but I don't know the directory structure for other platforms |
Author
|
Note, these updates seem to have broken darkmode support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Resolves #105.
Solution
Manually added the offline extension folder to the project and told electron-builder to package it with applications
Other changes (e.g. bug fixes, UI tweaks, small refactors)
Also upgraded Electron to 15 and refactored some code so that it doesn't complain about deprecations. There was also a memory leak that kept occurring that is not fixed.