feat(docs): document AES block cypher #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scriptandcompile
commented
Jun 7, 2024
There was a problem hiding this comment.
I had meant to break each of these into their own commit, but I screwed up the patch add on the last one. Oopsie.
alexfertel
previously approved these changes
Jun 8, 2024
| @@ -74,6 +143,17 @@ const INV_SBOX: [Byte; 256] = [ | |||
| ]; | |||
|
|
|||
| #[rustfmt::skip] | |||
There was a problem hiding this comment.
Let's put the attribute macro below the doc comments.
src/ciphers/aes.rs
Outdated
Comment on lines
340
to
343
| /// # Panics | ||
| /// | ||
| /// This function will not panic. | ||
| /// |
There was a problem hiding this comment.
If a function doesn't panic, then this section can be skipped.
alexfertel
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
second verse, same as the first!